[Merged by Bors] - chore: cleanup of adaptation notes#37922
Closed
[Merged by Bors] - chore: cleanup of adaptation notes#37922
Conversation
Contributor
kim-em
commented
Apr 11, 2026
kim-em
commented
PR summary 9036ce5439Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for Decrease in tech debt: (relative, absolute) = (6.02, 1.29)
Current commit 99fb87ba04 You can run this locally as
|
grunweg
reviewed
Apr 11, 2026
Contributor
grunweg
left a comment
grunweg
left a comment
There was a problem hiding this comment.
Thanks for doing this! Just two small questions.
bors d+
| rw [if_neg] | ||
| · exact terminalIsTerminal | ||
| · #adaptation_note /-- 2024-03-24 | ||
| Previously the universe annotation was not needed here. -/ |
Contributor
There was a problem hiding this comment.
Can you say a word about this change?
Contributor
Author
There was a problem hiding this comment.
I'll revert this one for now.
Contributor
|
✌️ kim-em can now approve this pull request. To approve and merge a pull request, simply reply with |
grunweg
added
the
tech debt
mathlib-triage
Bot
added
the
delegated
JovanGerb
reviewed
Apr 13, 2026
mathlib-merge-conflicts
Bot
added
the
merge-conflict
|
This pull request has conflicts, please merge |
kim-em
force-pushed
the
cleanup_adaptation_notes
branch
from
728c05e to
cb009db
Compare
github-actions
Bot
removed
the
merge-conflict
JovanGerb
reviewed
Apr 18, 2026
Contributor
JovanGerb
left a comment
JovanGerb
left a comment
There was a problem hiding this comment.
(My review comment from the previous review is still unaddressed)
Contributor
Author
|
bors merge |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.